ESS-4162: Unpinning pandas#150
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR aims to support pandas 3 by addressing a pandas 3 slicing issue in Client.get() when start=None, and updates test fixtures/expectations to match the new default start timestamp behavior.
Changes:
- Updated the default
startused byClient.get()requests from a negative nanoseconds value to0(Unix epoch) to avoid pandas 3 slicing issues. - Refactored series slicing logic in
Client.get()to sort once (when needed) and then slice. - Updated URL expectations in tests/response cases to match the new
start=0default.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
datareservoirio/client.py |
Adjusts default start behavior and refactors slicing/sorting for pandas 3 compatibility. |
tests/test_client.py |
Updates expected request URL for default start behavior. |
tests/response_cases.py |
Updates mocked response keys (URLs) to match the new default request parameters. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
branislav-jenco-4ss
requested review from
bjorn-einar-bjartnes-4ss and
wojciech-bochniarz-4ss
bjorn-einar-bjartnes-4ss
approved these changes
May 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unpinnng pandas from
< 3and fixing the accompanying issue where in pandas 3, if the user supplied None to thestartparameter ofclient.get, the access slicing wouldn't work properly b/c of an int64 underflow.